fix: Use the reserved listener address for Docker port bindings#131
Open
nowooj wants to merge 1 commit into
Open
fix: Use the reserved listener address for Docker port bindings#131nowooj wants to merge 1 commit into
nowooj wants to merge 1 commit into
Conversation
|
PR author is not in the allowed authors list. |
nowooj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes
GetPortto derive DockerPortBinding.HostIPandHostPortfrom the actual TCP listener address.Previously, interchaintest reserved ports by opening a listener on
127.0.0.1:<port>, but returned a Docker port binding withHostIP: "0.0.0.0". This meant the reserved host address and the Docker publish addresscould differ.
With this change, the returned
PortBindingis built from the listener itself:Motivation
OpenListener is the source of truth for reserving an available host port. The Docker PortBinding should use the same bound address rather than independently choosing a different host IP.
This matters on newer Docker versions where bridge networking and port publishing behavior has been tightened. Docker Engine 28 changed port publishing and bridge-network firewall behavior, and Docker documents that
binding to 127.0.0.1 restricts the published port to the Docker host.
Behavior Change
Instead of always publishing reserved ports on 0.0.0.0, interchaintest now publishes the port on the same IP address that was actually reserved by the temporary listener.
For the current OpenListener implementation, this means Docker receives 127.0.0.1:, matching the listener reservation.